[Freeipa-devel] [PATCH] Check for valid ID ranges and ID overlaps between domains

[Jakub Hrozek]

On Tue, 2009-05-05 at 08:43 -0400, Simo Sorce wrote:
> 
> nack
> 
> We do not require to always set id ranges, they are optional and more
> a
> filter than anything else.
> At most overlapping ranges should give a warning, and absence of
> ranges
> in a domain is fine too.

OK, a new incarnation of the patch that just prints a DEBUG(1, ..) is
attached. 

> 
> Second I don't get the utility of the double while loop in that
> function, what's for ?

Since the domain limits are pretty arbitrary and not sorted in any way,
compares the first domain with all others starting with the next
(=second), then second domain with all others starting with the next
(=third), ..

I think that adds up to (n^2)/2 cycles for n domains.

Jakub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Check-for-valid-ID-range-domains-overlap.patch
Type: text/x-patch
Size: 1936 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090511/6fdee63d/attachment.bin>