[Freeipa-devel] [PATCH] Manpages generation

[Jakub Hrozek]

On Wed, 2009-05-13 at 11:42 +0200, Sumit Bose wrote: 
> Jakub Hrozek schrieb:
> > The attached patch provides a set of make rules for generating UNIX
> > manual pages from DocBook 4.5 source  as well as sample manpage for
> > sss_useradd. Automatic generation of manual pages during "make" process
> > is tunable with config parameter "--with-manpages". To rebuild the man
> > pages separately, use the "make doc" target. Before building, the
> > manpages are validated using a DTD schema.
> > 
> 
> Hi Jakub,
> 
> I like the patch and it works for me, but I have a few comments:
> 
> - there is a whitespace error in sss_useradd.8.xml at line 34
Fixed, thanks

> - why are you using the profile version of the stylesheet
A bug, sorry. Fixed now.

> - can you add libxml2 and libxslt to the build requirements in sssd.spec
> - I would prefer to have the man pages build by default and a
>   --without-manpages configure option for people who do not want to
>   install the xml/xslt stuff to generate the man pages

Done, too, although the packaging might change when we migrate to
Automake. 

I also recall that Simo did want to include the groff-formatted manpages
in the release tarballs. Simo, did you have something the "build-docs"
script in Samba4 tree in mind?

Thank you for the review!

Jakub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Manpage-generation.patch
Type: text/x-patch
Size: 14053 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090513/8e3f343a/attachment.bin>