[Freeipa-devel] [PATCH] Manpages generation

[Sumit Bose]

Jakub Hrozek schrieb:
> On Wed, 2009-05-13 at 11:42 +0200, Sumit Bose wrote: 
>> Jakub Hrozek schrieb:
>>> The attached patch provides a set of make rules for generating UNIX
>>> manual pages from DocBook 4.5 source  as well as sample manpage for
>>> sss_useradd. Automatic generation of manual pages during "make" process
>>> is tunable with config parameter "--with-manpages". To rebuild the man
>>> pages separately, use the "make doc" target. Before building, the
>>> manpages are validated using a DTD schema.
>>>
>> Hi Jakub,
>>
>> I like the patch and it works for me, but I have a few comments:
>>
>> - there is a whitespace error in sss_useradd.8.xml at line 34
> Fixed, thanks
> 
>> - why are you using the profile version of the stylesheet
> A bug, sorry. Fixed now.
> 
>> - can you add libxml2 and libxslt to the build requirements in sssd.spec
>> - I would prefer to have the man pages build by default and a
>>   --without-manpages configure option for people who do not want to
>>   install the xml/xslt stuff to generate the man pages
> 
> Done, too, although the packaging might change when we migrate to
> Automake. 

I don not know how to tell autotools to do this, but it would be nice to
have something similar to:

-doc:: $(MANPAGES)
+doc:: $(if $(HAVE_MANPAGES),$(MANPAGES), \
+        $(info Please use configure option --with-manpages to enable

in Makefile.in to avoid strange messages when 'make doc' is called after
configure --without-manpages.

> 
> I also recall that Simo did want to include the groff-formatted manpages
> in the release tarballs. Simo, did you have something the "build-docs"
> script in Samba4 tree in mind?
> 

+1 for groff-formatted manpages in the tarballs

ACK for the patch, but I think you should talk to Stephen if this patch
or the autotools patch should come first.

bye,
Sumit