[Freeipa-devel] [PATCHES][SSSD] Big automake conversion

Sumit Bose sbose at redhat.com
Tue May 19 08:02:28 UTC 2009


Stephen Gallagher schrieb:
> Warning: these patches are large.
> 
> General comments:
>     I have changed the versioning of the shared objects that we build in
> order to be more in keeping with the GNU coding style. Instead of
> keeping the shared object version in line with the sssd version, they
> will instead be versioned by their own interface. As such, I have
> re-versioned them to .1.0.0 at this time.
>     I am building our shared libraries with libtool. I have already had
> the requisite debate with certain parties, and I will be responsible for
> maintaining this.
> 
> 0001: Fix some problems with the automake build in the common
> directories so that parallel builds work.
> 
> 0002: Hack together a Makefile.am for building libreplace recursively
> 
> 0003: Convert the entire SSSD server daemon, plugins, etc. to automake
> 
> 0004: Convert the sss_client libraries to automake.
> 
> 0005: Convert the top-level of the SSSD to automake.
> The sssd.spec %install section uses a workaround to deal with the fact
> that our automake build is installing a bunch of files we don't need.
> I'm going to fix this eventually, but for the time being it was easier
> to simply remove them from the buildroot before packaging.
> 
>
ACK to all.

The patches apply cleanly, everything is build and it even works in koji
(http://koji.fedoraproject.org/koji/taskinfo?taskID=1362791). Great work.

I have only one minor request, can you update BUILD.txt?

bye,
Sumit




More information about the Freeipa-devel mailing list