[Freeipa-devel] [PATCHES][SSSD] Big automake conversion

[Stephen Gallagher]

On 05/19/2009 04:02 AM, Sumit Bose wrote:
> Stephen Gallagher schrieb:
>> Warning: these patches are large.
>>
>> General comments:
>>     I have changed the versioning of the shared objects that we build in
>> order to be more in keeping with the GNU coding style. Instead of
>> keeping the shared object version in line with the sssd version, they
>> will instead be versioned by their own interface. As such, I have
>> re-versioned them to .1.0.0 at this time.
>>     I am building our shared libraries with libtool. I have already had
>> the requisite debate with certain parties, and I will be responsible for
>> maintaining this.
>>
>> 0001: Fix some problems with the automake build in the common
>> directories so that parallel builds work.
>>
>> 0002: Hack together a Makefile.am for building libreplace recursively
>>
>> 0003: Convert the entire SSSD server daemon, plugins, etc. to automake
>>
>> 0004: Convert the sss_client libraries to automake.
>>
>> 0005: Convert the top-level of the SSSD to automake.
>> The sssd.spec %install section uses a workaround to deal with the fact
>> that our automake build is installing a bunch of files we don't need.
>> I'm going to fix this eventually, but for the time being it was easier
>> to simply remove them from the buildroot before packaging.
>>
>>
> ACK to all.
> 
> The patches apply cleanly, everything is build and it even works in koji
> (http://koji.fedoraproject.org/koji/taskinfo?taskID=1362791). Great work.
> 
> I have only one minor request, can you update BUILD.txt?
> 
> bye,
> Sumit

BUILD.txt updated (affects only patch 0005, but reattaching all five for
convenience)

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Enable-parallel-builds-for-the-common-libraries.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090519/f5859d26/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Enable-automake-builds-for-libreplace.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090519/f5859d26/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-Enable-automake-builds-for-sssd-server.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090519/f5859d26/attachment-0002.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0004-Enable-automake-builds-for-sss_client.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090519/f5859d26/attachment-0003.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0005-Convert-top-level-of-SSSD-to-automake.patch
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090519/f5859d26/attachment-0004.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3258 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20090519/f5859d26/attachment.p7s>