[Freeipa-devel] why doesn't ipapython.ipautil.run() log what it's running?

[Rob Crittenden]

John Dennis wrote:
> Is there a reason why the run command (ipapython.ipautil.run()) does not 
> log what command it's running? It logs the stdout and stderr output of 
> the command (but without indicating what the log output is, so a lot of 
> time it just shows up as a blank line if there was no output). Shouldn't 
> it do something like this:
> 
> logging.info("args=%s" % " ".join(args))
> logging.info("stdout=%s" % stdout)
> logging.info("stderr=%s" % stderr)
> 
> instead of:
> 
> logging.info(stdout)
> logging.info(stderr)
> 
> Without knowing what was run and what it's arguments were the stdout and 
> stderr messages are almost useless.
> 

Guess it never came up before. Seems to make sense to be more explicit.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20091013/0512adb0/attachment.bin>