[Freeipa-devel] [PATCH] Added error handler for ipa_cmd().

[Adam Young]

On 09/28/2010 07:20 PM, Endi Sukma Dewata wrote:
> Hi,
>
> Please review the attached patch. It can be tested by moving one of
> the JSON files in test/data somewhere else. Thanks!
>
> The ipa_cmd() has been modified such that when an error occurs a
> dialog box will appear showing the error message with 2 buttons:
> Retry and Cancel. If Retry is clicked, it will attempt to execute
> the same operation again. If Cancel is clicked, the operation will
> be canceled and the control is returned to the caller.
>
> The associate.js, details.js, entity.js, search.js, and webui.js
> have been modified to display the error message inside the page.
> This behavior can be changed in the future (e.g. redirect to error
> page).
>
> The navigation.js and webui.js have been modified to render only
> the visible tabs. This improves the performance and reduce hidden
> errors.
>
> Some variables/functions also have been renamed for consistency.
>
> --
> Endi S. Dewata
>    
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


Endi, can you add in a Unit test for this?  If need be, extend the 
ipa_cmd so that it looks for an optional command line param that makes 
it try to fetch a .json file that doesn't exist:


Something like
var suffix = $.bbq.get("cmd_suffix");
if (suffix){
method += suffix;
}
method += '.json';

...




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20100928/5b12d693/attachment.htm>