[Freeipa-devel] [PATCH] 137 Entitlement registration.

[Adam Young]

On 04/12/2011 03:06 PM, Endi Sukma Dewata wrote:
> The entitlement facet will show the appropriate buttons depending on
> the entitlement status. If it's not registered, the facet will show
> a Register button. If it's registered, the facet will show a Consume
> button.
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


Please make sure all String literals come from the interal.py messages 
plugin. New button labels are defined in entitle.js for Consume and 
Register.


The consume dialog should be limited to accepting only integer values: 
pass the validation pattern in to the text widget. that.entity = 
function(spec) {

We are starting to see a proliferation of code like this:

         if (spec instanceof Object){
             var factory = spec.factory || IPA.entity;
             entity = factory(spec);
         } else {
             var name = spec;
             entity = IPA.entity({name: name});
         }
         return that;
     };


Can we pull it into a helper function?


In dialog.js   the code that.entity = IPA.get_entity(that.entity_name);  
should happen before init, in the initial construction of the object.  
The goal is to remove init functions; please don't put any more code 
into them from here on out.  Same thing with Facet in entity.js


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110413/86277889/attachment.htm>