[Freeipa-devel] [PATCH] admiyo-0191-target-section-without-radio-buttons

Endi Sukma Dewata edewata at redhat.com
Thu Feb 10 23:46:28 UTC 2011


On 2/10/2011 5:02 PM, Adam Young wrote:
> On 02/10/2011 04:42 PM, Endi Sukma Dewata wrote:
>> On 2/10/2011 3:27 PM, Adam Young wrote:
>>>
>>
>> NACK. As discussed over IRC, the "is_dirty" functionality is not
>> working for permissions that have an "object by type" target.
>>
> Was worse than that, load was broken.

It still has some problems:

1. Updating a permission with a filter doesn't work. Clicking the update 
button didn't execute anything, the undo button didn't disappear.

2. Resetting the user details page is not working properly, some fields 
did not get reset. I think the addition of undo_span in widgets.js is 
not needed and causing a problem because not all (custom) widgets will 
call create_undo().

-- 
Endi S. Dewata




More information about the Freeipa-devel mailing list