[Freeipa-devel] [PATCH] admiyo-0191-target-section-without-radio-buttons

[Adam Young]

On 02/10/2011 06:46 PM, Endi Sukma Dewata wrote:
> On 2/10/2011 5:02 PM, Adam Young wrote:
>> On 02/10/2011 04:42 PM, Endi Sukma Dewata wrote:
>>> On 2/10/2011 3:27 PM, Adam Young wrote:
>>>>
>>>
>>> NACK. As discussed over IRC, the "is_dirty" functionality is not
>>> working for permissions that have an "object by type" target.
>>>
>> Was worse than that, load was broken.
>
> It still has some problems:
>
> 1. Updating a permission with a filter doesn't work. Clicking the 
> update button didn't execute anything, the undo button didn't disappear.
>
> 2. Resetting the user details page is not working properly, some 
> fields did not get reset. I think the addition of undo_span in 
> widgets.js is not needed and causing a problem because not all 
> (custom) widgets will call create_undo().
>
Filter not set was due to incomplete filter_text attribute-rights  work 
around
undo_span is now wrapped in jquery select, so that it there is no undo, 
it works correctly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0191-target-section-without-radio-buttons.patch
Type: text/x-patch
Size: 20917 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110211/31130c44/attachment.bin>