[Freeipa-devel] [PATCH] Host details adjustments.

Adam Young ayoung at redhat.com
Thu Jan 13 04:12:34 UTC 2011


On 01/12/2011 10:07 PM, Endi Sukma Dewata wrote:
> On 1/13/2011 9:11 AM, Endi Sukma Dewata wrote:
>> The attached patch should address issue #1 and #2 in this bug:
>> https://fedorahosted.org/freeipa/ticket/670
>>
>> The labels for the following fields in Host details page have been
>> changed:
>> - fqdn: Fully Qualified Host Name
>> - serverhostname: Host Name
>>
>> The ipa_details_field_create_input() and _ipa_create_text_input()
>> has been converted into methods in ipa_details_field class. The code
>> has been modified to display read-only fields as labels instead
>> of disabled text fields.
>
> Rebased against the latest.
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
can you replace the huge if-else block in details.js line 282?  You cna 
leave the comment about  class-specific implementation, but the code 
does nothing of use as is.  Other than that, ACK.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110112/471638f9/attachment.htm>


More information about the Freeipa-devel mailing list