[Freeipa-devel] [PATCH] 0262-validate-ints

[Endi Sukma Dewata]

On 7/5/2011 9:37 AM, Adam Young wrote:
>

Some issues:

1. The validation process should stop after finding the first problem. 
So the validate_integers() needs to return a value which is then checked 
by validate() to determine if it should continue.

2. This is actually an existing problem, so it can be addressed later. 
If a widget only has a metadata but not param_info (not sure if this 
ever happens) it will only execute integer validation but not the 
pattern validation. The metadata and param_info are actually the same 
thing so we should be able to merge them, but it might require 
significant changes.

3. There are jslint warnings. The 'message' variable declaration needs 
to be moved into validate_integers().

-- 
Endi S. Dewata