[Freeipa-devel] [PATCH] 0262-validate-ints

[Adam Young]

On 07/05/2011 02:27 PM, Endi Sukma Dewata wrote:
> On 7/5/2011 9:37 AM, Adam Young wrote:
>>
>
> Some issues:
>
> 1. The validation process should stop after finding the first problem. 
> So the validate_integers() needs to return a value which is then 
> checked by validate() to determine if it should continue.
Not really necessary.

>
> 2. This is actually an existing problem, so it can be addressed later. 
> If a widget only has a metadata but not param_info (not sure if this 
> ever happens) it will only execute integer validation but not the 
> pattern validation. The metadata and param_info are actually the same 
> thing so we should be able to merge them, but it might require 
> significant changes.
Fixed

>
> 3. There are jslint warnings. The 'message' variable declaration needs 
> to be moved into validate_integers().
>
Fixed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0262-1-validate-ints.patch
Type: text/x-patch
Size: 4006 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110705/082abbe9/attachment.bin>