[Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

[Endi Sukma Dewata]

On 7/8/2011 10:06 AM, Adam Young wrote:
>

Some issues:

1. The new code in IPA.widget.test_dirty() seems to be redundant.

     if ((that.values.length === 0) &&
         (values.length === 1) &&
         values[0] === ""){
         return false;
     }

It's already covered by a similar code above it.

2. The commented code in details.js:167 can be removed (and 158 too).

3. Instead of returning empty array, the details_tests.js:173 should 
return the overridden method's return value.

     return widget.widget_save();

-- 
Endi S. Dewata