[Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

[Adam Young]

On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:
> On 7/8/2011 10:06 AM, Adam Young wrote:
>>
>
> Some issues:
>
> 1. The new code in IPA.widget.test_dirty() seems to be redundant.
>
>     if ((that.values.length === 0) &&
>         (values.length === 1) &&
>         values[0] === ""){
>         return false;
>     }
>
> It's already covered by a similar code above it.

Not quite.  This happens when the widget defaults a blank field to [""].
>
> 2. The commented code in details.js:167 can be removed (and 158 too).
Done
>
> 3. Instead of returning empty array, the details_tests.js:173 should 
> return the overridden method's return value.
>
>     return widget.widget_save();
>
Just keeps the test from breaking.  Not really checking anything
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0266-1-clear-errors-on-reset.patch
Type: text/x-patch
Size: 3001 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110708/18507177/attachment.bin>