[Freeipa-devel] [PATCH] 831 fix removing external netgroup hosts

Jan Cholasta jcholast at redhat.com
Tue Jul 19 13:52:38 UTC 2011


On 19.7.2011 15:34, Rob Crittenden wrote:
> When removing an external host member it was still showing in the return
> data as a member despite being removed properly.
>
> ticket https://fedorahosted.org/freeipa/ticket/1492
>

You store the result of ldap.get_entry in a variable and never use it 
again. IMO you should either use the result (as Martin did in patch 98) 
or remove the ldap.get_entry line altogether (please correct me if I'm 
missing something).

Honza

-- 
Jan Cholasta




More information about the Freeipa-devel mailing list