[Freeipa-devel] [PATCH] 831 fix removing external netgroup hosts

[Rob Crittenden]

Jan Cholasta wrote:
> On 19.7.2011 15:34, Rob Crittenden wrote:
>> When removing an external host member it was still showing in the return
>> data as a member despite being removed properly.
>>
>> ticket https://fedorahosted.org/freeipa/ticket/1492
>>
>
> You store the result of ldap.get_entry in a variable and never use it
> again. IMO you should either use the result (as Martin did in patch 98)
> or remove the ldap.get_entry line altogether (please correct me if I'm
> missing something).
>
> Honza
>

Nope, goof on my part, updated patch attached. It worked in my test b/c 
I only had a single external host.

Updated patch attached.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-831-2-netgroup.patch
Type: text/x-diff
Size: 1820 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110719/49a23909/attachment.bin>