[Freeipa-devel] [PATCH] admiyo-0206-2-Use-modified-entity-find-commands-for-associations

[Adam Young]

No search widget.  This will keep the UI from throwing an Error, but 
doesn't give a way to get results beyond the first 100


On 03/02/2011 01:20 PM, Endi Sukma Dewata wrote:
> On 3/2/2011 10:56 AM, Adam Young wrote:
>> This version uses the search widget. A little more intrusive than I
>> wanted, but if fixes the issue with
>> https://fedorahosted.org/freeipa/ticket/1011
>
> I tested this with Group's Member User:
>
> The Add button doesn't open a dialog box, but it tries to create the 
> content of the dialog box under the search table.
>
> The Delete button does open a dialog box, but it doesn't delete the 
> member, then it goes back to group's search page.
>
> Another thing, I was expecting the entire that.table = IPA.table_widget
> to be replaced by that.table = IPA.search_widget so we don't have to 
> do this:
>   if (that.columns.length == 1) {
>     // do things with table widget
>   } else {
>     // do things with search widget
>   }
> but it might be to complicated for this release.
>
>>>>> 604: that.relationship_filter = spec.relationship_filter;
>>>>> 899: var relationship_filter = 'in_' + that.entity_name;
>
>> Removed the code at 604 for now. We'll see what the right solution is
>> when we start implementing the others. I don't like how the code had to
>> be split up due to the init function.
>
> Then I'd ask that you put a note above 899, something like this:
> // TODO: fix hard-coded relationship filter
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0206-5-Use-modified-entity-find-commands-for-associations.patch
Type: text/x-patch
Size: 4837 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110302/ebaee377/attachment.bin>