[Freeipa-devel] [PATCH] 163 Fixed adder dialog title.

Endi Sukma Dewata edewata at redhat.com
Tue May 24 15:17:33 UTC 2011


On 5/24/2011 9:43 AM, Adam Young wrote:
> On 05/23/2011 05:32 PM, Endi Sukma Dewata wrote:
>> The IPA.entity_builder has been fixed to use the correct title
>> for the entity's adder dialog.
>>
>> Ticket #1239

> Seems like a lot of duplication in the messages. Shouldn't it be more
> along the lines of the other ones that are:
>
> "Add " + Entity.label.

Two problems with that:

1. The entity labels are plurals, we don't have singular labels for entity.

2. The word order could be different in some languages. We should use a 
translatable template: "Add ${entity}". This depends on #1.

I think the current patch is sufficient. We can improve it later when #1 
is addressed.

-- 
Endi S. Dewata




More information about the Freeipa-devel mailing list