[Freeipa-devel] [PATCH] 069 Improve interactive mode for DNS plugin
Martin Kosek
mkosek at redhat.com
Fri May 27 07:53:14 UTC 2011
On Thu, 2011-05-26 at 21:00 +0200, Jan Cholasta wrote:
> On 26.5.2011 14:32, Martin Kosek wrote:
> > Interactive mode for commands manipulating with DNS records
> > (dnsrecord-add, dnsrecord-del) is not usable. This patch enhances
> > the server framework with new callback for interactive mode, which
> > can be used by commands to inject their own interactive handling.
> >
> > The callback is then used to improve aforementioned commands'
> > interactive mode.
> >
> > https://fedorahosted.org/freeipa/ticket/1018
> >
>
> ACK, works fine.
>
> Just a minor thing:
>
> $ git apply
> freeipa-mkosek-069-improve-interactive-mode-for-dns-plugin.patch
> freeipa-mkosek-069-improve-interactive-mode-for-dns-plugin.patch:33:
> trailing whitespace.
>
> freeipa-mkosek-069-improve-interactive-mode-for-dns-plugin.patch:41:
> trailing whitespace.
>
> freeipa-mkosek-069-improve-interactive-mode-for-dns-plugin.patch:289:
> trailing whitespace.
>
> freeipa-mkosek-069-improve-interactive-mode-for-dns-plugin.patch:193:
> new blank line at EOF.
> +
> warning: 4 lines add whitespace errors.
>
> Honza
>
Yeah, I fixed these. Nothing in my workflow reports me such errors, I
must enhance my .vimrc to do it for me.
Martin
More information about the Freeipa-devel
mailing list