[Freeipa-devel] [PATCH 75] log dogtag errors

Petr Viktorin pviktori at redhat.com
Fri Apr 27 08:45:01 UTC 2012


On 04/20/2012 08:07 PM, John Dennis wrote:
> Ticket #2622
>
> If we get an error from dogtag we always did raise a
> CertificateOperationError exception with a message describing the
> problem. Unfortuanately that error message did not go into the log,
> just sent back to the caller. The fix is to format the error message
> and send the same message to both the log and use it to initialize the
> CertificateOperationError exception.
>

The patch contains five hunks with almost exactly the same code, 
applying the same changes in each case.
Wouldn't it make sense to move the _sslget call, parsing, and error 
handling to a common method?

-- 
Petr³




More information about the Freeipa-devel mailing list