[Freeipa-devel] [PATCH 75] log dogtag errors

[John Dennis]

On 04/27/2012 04:45 AM, Petr Viktorin wrote:
> On 04/20/2012 08:07 PM, John Dennis wrote:
>> Ticket #2622
>>
>> If we get an error from dogtag we always did raise a
>> CertificateOperationError exception with a message describing the
>> problem. Unfortuanately that error message did not go into the log,
>> just sent back to the caller. The fix is to format the error message
>> and send the same message to both the log and use it to initialize the
>> CertificateOperationError exception.
>>
>
> The patch contains five hunks with almost exactly the same code,
> applying the same changes in each case.
> Wouldn't it make sense to move the _sslget call, parsing, and error
> handling to a common method?
>

Yes it would and ordinarily I would have taken that approach. However on 
IRC (or phone?) with Rob we decided not to perturb the code too much for 
this particular issue because we intend to refactor the code later. This 
was one of the last patches destined for 2.2 which is why we took the 
more conservative approach.

-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/