[Freeipa-devel] [PATCH] 162 Web UI password is going to expire in n days notification

[Endi Sukma Dewata]

On 6/28/2012 8:59 AM, Petr Vobornik wrote:
> On 06/27/2012 04:33 PM, Petr Vobornik wrote:
>> On 06/27/2012 03:54 AM, Endi Sukma Dewata wrote:
>>> On 6/26/2012 9:46 AM, Petr Vobornik wrote:
>>>> This is patch is more like a draft.
>>>>
>>>> I'm not sure where to display the 'password is going to expire'
>>>> notification.
>>>>
>>>> I was deciding between:
>>>> 1) red bold text in Web UI header
>>>> 2) popup dialog after Web UI initialization
>>>>
>>>> I don't like unwanted pop-up dialogs so I used first option.
>>>
>>> If we only support 1 short message I'd prefer option #1. Some users
>>> might not want to reset the password immediately, so they need to be
>>> constantly reminded about the password expiration.
>>>
>>> If the message is too long, or we want to support multiple messages (not
>>> just for password expiration), we can show a message icon like in the
>>> upper right corner of Fedora desktop. When you click it it will open a
>>> dialog box listing all messages. In this dialog you can delete each
>>> message. The icon will disappear only if there's no message left.
>>>
>>>> I didn't make a 'password reset link' because it is done in user's
>>>> detail page and a link there is right next to this notification.
>>>
>>> I'd say the message should include a link, something like this:
>>>
>>> Your password will expire in n days. [Reset your password].
>>>
>>> The link is important because:
>>>
>>> * Without the link the message doesn't tell you what to do or how
>>> to reset the password.
>>> * Users might not realize that the [Logged In As: <user>] is a link
>>> that can bring them to their profile page.
>>> * Even if they're in the right page, they might not know there's a
>>> reset password link in the action panel.
>>>
>>> The [Reset your password] link can open the Password Reset dialog for
>>> the current user, regardless of the current page. To avoid confusion the
>>> dialog probably should be changed to show the username of the user being
>>> updated.
>>>
>>> What do you think?
>>>
>>
>> I like it.
>>
>> I'll add the reset link next to the message. If we encounter more cases
>> we can moved it to the notification icon functionality.
>>
>> I found more non-existing options used and also #2876. I'll return to
>> this ticket when I fix these regression.
>>
> Here's an updated version.
>
> It displays the warning with reset link next to it. I slightly modified
> user_password_dialog to be usable alone.

ACK. I have some suggestions below.

The reset link probably should be blue to be consistent with the other 
links, but maybe it doesn't go well with dark background. Or you can 
make the link red (and the whole message clickable) to make sure it's 
clear that it's part of the error message, not a permanent part of the 
UI like the "Logged in as". Or make the link message more explicit: 
"Click here to reset your password."

When you reset the password, a confirmation dialog will appear on top of 
the password reset dialog. I think in general we should avoid nesting 
dialog. So the password dialog should be closed first then open the 
confirmation/error dialog. The password dialog can be reopened if 
something goes wrong.

Btw, the style of the confirmation dialog is different from the other 
dialog. Is this intentional?

One thing I noticed also, when you login with expired password, after 
you reset the password it will briefly show the login page again before 
showing the UI. I think the login dialog should close immediately once 
you click the button.

-- 
Endi S. Dewata