[Freeipa-devel] [PATCH] 162 Web UI password is going to expire in n days notification

[Petr Vobornik]

On 06/28/2012 10:35 PM, Endi Sukma Dewata wrote:
>
> ACK. I have some suggestions below.

Pushed to master.

>
> The reset link probably should be blue to be consistent with the other
> links, but maybe it doesn't go well with dark background. Or you can
> make the link red (and the whole message clickable) to make sure it's
> clear that it's part of the error message, not a permanent part of the
> UI like the "Logged in as". Or make the link message more explicit:
> "Click here to reset your password."

I tried the blue and indeed it doesn't go well with dark background. I 
will think about the other options.

>
> When you reset the password, a confirmation dialog will appear on top of
> the password reset dialog. I think in general we should avoid nesting
> dialog. So the password dialog should be closed first then open the
> confirmation/error dialog. The password dialog can be reopened if
> something goes wrong.

Also same type of dialog is used for validation. And I completely agree 
we should change it. In gnome shell you have to move mouse a lot. Also 
it pauses execution of scripts so page can't update on the background 
when user is reading the message.

https://fedorahosted.org/freeipa/ticket/2884

>
> Btw, the style of the confirmation dialog is different from the other
> dialog. Is this intentional?

It's plain JavaScript alert dialog. I looked in git log and it's there 
from the beginning.

>
> One thing I noticed also, when you login with expired password, after
> you reset the password it will briefly show the login page again before
> showing the UI. I think the login dialog should close immediately once
> you click the button.
>

In my environment it's usually so fast I can't notice it. I have to try 
it on slower machine or in vm to see how annoying it can be.

-- 
Petr Vobornik