[Freeipa-devel] [PATCHES] 127-136 LDAP code refactoring (Part 2)

[Petr Viktorin]

On 01/17/2013 06:27 PM, Petr Viktorin wrote:
> Hello,
> This is the first batch of changes aimed to consolidate our LDAP code.
> Each should be a self-contained change that doesn't break anything.
>
> These patches do some general cleanup (some of the changes might seem
> trivial but help a lot when grepping through the code); merge the common
> parts LDAPEntry, Entry and Entity classes; and move stuff that depends
> on an installed server out of IPASimpleLDAPObject and SchemaCache.
>
> I'm posting them early so you can see where I'm going, and so you can
> find out if your work will conflict with mine.

Here is a second batch of patches. I'm keeping them small so they're 
easier to digest (and rebase, should that be necessary). If you prefer 
big patches, just squash them.
Obviously, they apply on top of the previous batch.

Here we introduce a base class, LDAPConnection, from which IPAdmin and 
ldap2 inherit. This makes IPAdmin support both interfaces, its own old 
one and the new common one.
Both IPAdmin and ldap2 work with the common Entry class, LDAPEntry, 
which also has both the old and new interface for the moment.
To use a hyperbole, the rest of the work is simply rewriting the 
codebase to use the new interfaces.
And testing.



https://fedorahosted.org/freeipa/ticket/2660

-- 
Petr³


-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0127-Move-SchemaCache-and-IPASimpleLDAPObject-to-ipaserve.patch
Type: text/x-patch
Size: 45336 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0128-Start-LDAPConnection-a-common-base-for-ldap2-and-IPA.patch
Type: text/x-patch
Size: 12345 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0129-Make-IPAdmin-not-inherit-from-IPASimpleLDAPObject.patch
Type: text/x-patch
Size: 6272 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0130-Move-schema-related-methods-to-LDAPConnection.patch
Type: text/x-patch
Size: 6636 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0131-Move-DN-handling-methods-to-LDAPConnection.patch
Type: text/x-patch
Size: 4151 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0132-Move-filter-making-methods-to-LDAPConnection.patch
Type: text/x-patch
Size: 13204 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0133-Move-entry-finding-methods-to-LDAPConnection.patch
Type: text/x-patch
Size: 21693 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0134-Remove-unused-proxydn-functionality-from-IPAdmin.patch
Type: text/x-patch
Size: 5761 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0135-Move-entry-add-update-remove-rename-to-LDAPConnectio.patch
Type: text/x-patch
Size: 12385 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0136-Implement-some-of-IPAdmin-s-legacy-methods-in-terms-.patch
Type: text/x-patch
Size: 5034 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20130121/73288299/attachment-0009.bin>