[Freeipa-devel] [PATCHES] 127-136 LDAP code refactoring (Part 2)

[Jan Cholasta]

Hi,

On 21.1.2013 18:38, Petr Viktorin wrote:
> Here is a second batch of patches. I'm keeping them small so they're
> easier to digest (and rebase, should that be necessary). If you prefer
> big patches, just squash them.
> Obviously, they apply on top of the previous batch.
>
> Here we introduce a base class, LDAPConnection, from which IPAdmin and
> ldap2 inherit. This makes IPAdmin support both interfaces, its own old
> one and the new common one.
> Both IPAdmin and ldap2 work with the common Entry class, LDAPEntry,
> which also has both the old and new interface for the moment.
> To use a hyperbole, the rest of the work is simply rewriting the
> codebase to use the new interfaces.
> And testing.
>

So far I have just one small nitpick: could you please rename 
LDAPConnection to LDAPClient? It does more than just connecting, so it 
should have more suitable name IMHO. Also, the "conn" attribute of 
LDAPConnection might be confusing to someone (connection in connection?).

Honza

-- 
Jan Cholasta