[Freeipa-devel] [PATCH 0238] ipaldap: Override conversion of nsds5replicalastupdatestart

[Martin Kosek]

On 07/02/2014 08:14 AM, Jan Cholasta wrote:
> On 1.7.2014 16:45, Tomas Babej wrote:
>> Hi,
>>
>> The replication related attributes nsds5replicalastupdatestart and
>> nsds5replicalastupdateend have special behaviour implemented in 389,
>> as follows:
>>
>> In case they are explicitly requested for and not set, 0 is returned.
>>
>> However, 0 is not a valid value for LDAP Generalized time. Thus
>> we need to add these attributes to the _SYNTAX_OVERRIDE dictionary,
>> overriding their conversion to datetime and converting them to
>> string instead, which preserves the old behaviour expected by the
>> replication codebase.
>>
>> https://fedorahosted.org/freeipa/ticket/4350
>>
>> Note: This makes patch 236 obsolete.
>> Note II: This is a short-term fix from my point of view. Ticket to
>> resolve the underlying issue has been filed to 389:
>>
>> https://fedorahosted.org/389/ticket/47836
> 
> It should be unicode, not str, if you want old behavior.
> 

Given that Tomas is away and we want this in 4.0, I revisited the patch add
fixed the conversion + added 2 more date attributes which would cause issues
with "ipa-replica-manage HOST -v". Now it works:

# ipa-replica-manage list server.example.com -v
vm-086.idm.lab.bos.redhat.com: replica
  last init status: None
  last init ended: None
  last update status: 0 Replica acquired successfully: Incremental update started
  last update ended: None

# ipa-replica-manage list -v replica.example.com
vm-111.idm.lab.bos.redhat.com: replica
  last init status: 0 Total update succeeded
  last init ended: 2014-07-02 13:42:12+00:00
  last update status: 0 Replica acquired successfully: Incremental update succeeded
  last update ended: 2014-07-02 14:02:03+00:00

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-476-ipaldap-override-conversion-replication-agreement-va.patch
Type: text/x-patch
Size: 1507 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140702/6b768597/attachment.bin>