[Freeipa-devel] [PATCH 0238] ipaldap: Override conversion of nsds5replicalastupdatestart

[Martin Kosek]

On 07/02/2014 12:49 PM, Petr Viktorin wrote:
> On 07/02/2014 08:14 AM, Jan Cholasta wrote:
>> On 1.7.2014 16:45, Tomas Babej wrote:
>>> Hi,
>>>
>>> The replication related attributes nsds5replicalastupdatestart and
>>> nsds5replicalastupdateend have special behaviour implemented in 389,
>>> as follows:
>>>
>>> In case they are explicitly requested for and not set, 0 is returned.
>>>
>>> However, 0 is not a valid value for LDAP Generalized time. Thus
>>> we need to add these attributes to the _SYNTAX_OVERRIDE dictionary,
>>> overriding their conversion to datetime and converting them to
>>> string instead, which preserves the old behaviour expected by the
>>> replication codebase.
>>>
>>> https://fedorahosted.org/freeipa/ticket/4350
>>>
>>> Note: This makes patch 236 obsolete.
>>> Note II: This is a short-term fix from my point of view. Ticket to
>>> resolve the underlying issue has been filed to 389:
>>>
>>> https://fedorahosted.org/389/ticket/47836
>>
>> It should be unicode, not str, if you want old behavior.
>>
> 
> Since Tomáš is on vacation now, I made the change and tested it.
> 
> As Rob noted in the other patch thread, this problem also appears in
> `ipa-replica-manage list -v <host>`, where it's not benign as in the install
> case (the command aborts).
> The ipa-replica-manage list case will also fail on
> nsds5replicalastinit{start,end} conversion (note "init" instead of "update").
> 
> Updated patch attached.

Ah, I see you sent the same patch as I did :-) In that case, it is an ACK,
obviously.

Pushed to master: a5bb758978ffdccc5a985487d57856290428abf1

Martin