[Freeipa-devel] [PATCH] 0007 test group: remove group from protected group

Petr Viktorin pviktori at redhat.com
Mon Jul 28 16:41:24 UTC 2014


On 07/24/2014 03:11 PM, David Kupka wrote:
> Simple test scenario from ticket #4448.
>
> Last test will fail until patch freeipa-dkupka-0006 gets accepted.
>

Thanks! These look fine, but since the new tests don't require that the 
rest of `test_group` is run first, I encourage you to put them in a 
separate class.
This would ensure we don't add new inderdependencies between old and new 
tests in the future, making future test refactoring more straightforward.
Also, you can select to run just a single test class from a module, so 
testing a targeted fix is faster.
(And you can reuse group1, since the other test cleans it up)

See test_permission_plugin for an example.

-- 
Petr³




More information about the Freeipa-devel mailing list