[Freeipa-devel] [PATCH] 0007 test group: remove group from protected group

[David Kupka]

On 07/28/2014 06:41 PM, Petr Viktorin wrote:
> On 07/24/2014 03:11 PM, David Kupka wrote:
>> Simple test scenario from ticket #4448.
>>
>> Last test will fail until patch freeipa-dkupka-0006 gets accepted.
>>
>
> Thanks! These look fine, but since the new tests don't require that the
> rest of `test_group` is run first, I encourage you to put them in a
> separate class.
Put to separate class, as suggested. Looks better now.

> This would ensure we don't add new inderdependencies between old and new
> tests in the future, making future test refactoring more straightforward.
> Also, you can select to run just a single test class from a module, so
> testing a targeted fix is faster.
> (And you can reuse group1, since the other test cleans it up)
>
> See test_permission_plugin for an example.
>
The test still fails on current master but works fine with patch 
freeipa-dkupka-0006-2.

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0007-2-test-group-remove-group-from-protected-group.patch
Type: text/x-patch
Size: 3201 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140729/0d920827/attachment.bin>