[Freeipa-devel] [PATCH] 0007 test group: remove group from protected group

[Petr Viktorin]

On 07/29/2014 12:58 PM, David Kupka wrote:
> On 07/28/2014 06:41 PM, Petr Viktorin wrote:
>> On 07/24/2014 03:11 PM, David Kupka wrote:
>>> Simple test scenario from ticket #4448.
>>>
>>> Last test will fail until patch freeipa-dkupka-0006 gets accepted.
>>>
>>
>> Thanks! These look fine, but since the new tests don't require that the
>> rest of `test_group` is run first, I encourage you to put them in a
>> separate class.
> Put to separate class, as suggested. Looks better now.
>
>> This would ensure we don't add new inderdependencies between old and new
>> tests in the future, making future test refactoring more straightforward.
>> Also, you can select to run just a single test class from a module, so
>> testing a targeted fix is faster.
>> (And you can reuse group1, since the other test cleans it up)
>>
>> See test_permission_plugin for an example.
>>
> The test still fails on current master but works fine with patch
> freeipa-dkupka-0006-2.
>

Thanks! ACK, pushed to:
master: f7e00b9ad626e48a3e78a5ff68512642312a6d3d
ipa-4-1: f7e00b9ad626e48a3e78a5ff68512642312a6d3d
ipa-4-0: 19dd0c67bba41cd76fb1600a3d5f0293ec6f7c75


-- 
Petr³