[Freeipa-devel] [PATCH] 545 webui: Don't act on keyboard events which originated in, different dialog

[Adam Misnyovszki]

----- Original Message -----
> From: "Petr Vobornik" <pvoborni at redhat.com>
> To: "freeipa-devel" <freeipa-devel at redhat.com>
> Sent: Tuesday, February 25, 2014 2:20:11 PM
> Subject: [Freeipa-devel] [PATCH] 545 webui: Don't act on keyboard events which originated in, different dialog
> 
> Fixes issue when:
> 1. 2 dialogs are opened
> 2. top dialog's close button is focused
> 3. user presses enter to execute 'close' action
> 4. dialog is immediately closed (enter key is still pressed)
> 5. second dialog automatically receives focus (it's top dialog now)
> 6. user releases the key
> 7. second dialog reacts to keyup event - which is by default
> confirmation mixin's confirm event
> 8. UNDESIRED behavior occurs
> 
> Now confirmation mixin remembers which keys were pressed and released
> and reacts only to those which originated there.
> 
> https://fedorahosted.org/freeipa/ticket/4098
> --
> Petr Vobornik
> 

ACK
However, we should keep in mind, that there is an issue, when the ENTER key is pressed for a long time(ie more time than a keydown event is fired), the dialog starts to "blink". In my oppinion, this later behaviour is a wontfix, because firstly it is not easy to handle, secondly

> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel