[Freeipa-devel] [PATCH, slapi-nis] ID view-related patches to slapi-nis

[thierry bordaz]

On 10/29/2014 02:23 PM, Alexander Bokovoy wrote:
> On Wed, 29 Oct 2014, thierry bordaz wrote:
>> The patches fixed the test case in 
>> https://bugzilla.redhat.com/show_bug.cgi?id=1157989.
>> Few comments regarding the patch:
>>
>> * in backend_search_cb, it checks if the search is in one of the
>>   container. We need that cbdata.answer=FALSE at the end of the 
>> checking.
>>   Why not setting it systematically at the end.
> I've moved it to the end of the block.
>
>> * in backend_locate, 'target' is a duplicate of cbdata.target. But
>>   then when calling idview_replace_target_dn it may be changed.
>>   Will not it lead to a leak ?
> Good catch, thanks!
>
> Fixed version attached.
>
Hi Alexander,

The patches are good to me. Ack

thanks
thierry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141029/833582c9/attachment.htm>