[Freeipa-devel] [PATCH 0045] Add message for skipping NTP configuration during client install

[Gabe Alford]

On Thu, Apr 2, 2015 at 8:59 AM, Martin Basti <mbasti at redhat.com> wrote:

>  On 30/03/15 15:25, Gabe Alford wrote:
>
>   Hello,
>
>  With the merging of ticket 4842
> <https://fedorahosted.org/freeipa/ticket/4842>, I believe that half of
> ticket 3092 <https://fedorahosted.org/freeipa/ticket/3092> has been done.
> This patch just adds a message that says that NTP configuration was skipped
> which I believe should finish 3092
> <https://fedorahosted.org/freeipa/ticket/3092>.
>
>  Thanks,
>
>  Gabe
>
>
>  Hello, thank you for the patch.
>
> 1)
> IMO there should be:
> if *not* options.conf_ntp
>

So, if --no-ntp is not specified, print message that the client is skipping
NTP sync?


> 2)
> wouldnt be better to use just else?
>

I actually ran ipa-client-install with no options on a system where I used
'else', and it printed the skipping NTP sync when it should not have.
That is why the patch does not use 'else'.


>
> Martin
>
> --
> Martin Basti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150402/c73e245f/attachment.htm>