[Freeipa-devel] [PATCH] 0004 User life cycle: support of MODRDN to a new superior

[thierry bordaz]

On 04/14/2015 10:39 AM, Jan Cholasta wrote:
> Dne 12.4.2015 v 18:51 thierry bordaz napsal(a):
>> ...
>
> Please wrap long lines:
>
>                     new_dn = DN((self.obj.primary_key.name,
> entry_attrs[self.obj.primary_key.name]),
>                                 *entry_attrs.dn[1:])
>                     self._exc_wrapper(keys, options, ldap.move_entry)(
>                         entry_attrs.dn, new_dn)
>
> and:
>
>             self.conn.rename_s(dn, new_rdn, newsuperior=new_superior,
>                                delold=int(del_old))
>
>
> Also, you don't need to include your login in the author header (it's 
> part of your email address) or the reviewed by line in the commit 
> message (it's automatically added by ipatool when the commit is pushed).
>
Here is the updated patch. Thanks for the git tips :-)

thanks
theirry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbordaz-0004-5-User-life-cycle-allows-MODRDN-from-ldap2.patch
Type: text/x-patch
Size: 3681 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150415/d5350343/attachment.bin>