[Freeipa-devel] [PATCH] 0004 User life cycle: support of MODRDN to a new superior

Jan Cholasta jcholast at redhat.com
Thu Apr 16 06:51:32 UTC 2015


Dne 15.4.2015 v 19:03 thierry bordaz napsal(a):
> On 04/14/2015 10:39 AM, Jan Cholasta wrote:
>> Dne 12.4.2015 v 18:51 thierry bordaz napsal(a):
>>> ...
>>
>> Please wrap long lines:
>>
>>                     new_dn = DN((self.obj.primary_key.name,
>> entry_attrs[self.obj.primary_key.name]),
>>                                 *entry_attrs.dn[1:])
>>                     self._exc_wrapper(keys, options, ldap.move_entry)(
>>                         entry_attrs.dn, new_dn)
>>
>> and:
>>
>>             self.conn.rename_s(dn, new_rdn, newsuperior=new_superior,
>>                                delold=int(del_old))
>>
>>
>> Also, you don't need to include your login in the author header (it's
>> part of your email address) or the reviewed by line in the commit
>> message (it's automatically added by ipatool when the commit is pushed).
>>
> Here is the updated patch. Thanks for the git tips :-)

Thanks, ACK.

Pushed to master: c20009123f3e4456bdf63b9d406543cb0e50ffce

-- 
Jan Cholasta




More information about the Freeipa-devel mailing list