[Freeipa-devel] [PATCH] small fixes related to running dnssec tests in RHEL

Martin Basti mbasti at redhat.com
Mon Aug 24 14:32:47 UTC 2015



On 08/24/2015 02:36 PM, Martin Basti wrote:
>
>
> On 08/24/2015 01:28 PM, Oleg Fayans wrote:
>> Hi,
>>
>> Could anyone review this. We are really blocked with testing on RHEL 
>> and Patch 0005 fixes it. Thank you.
>>
>> On 08/21/2015 10:52 AM, Oleg Fayans wrote:
>>> Hi list,
>>>
>>> Here are the the fixes for https://fedorahosted.org/freeipa/ticket/5240
>>> plus pep8-related fixes, plus created a user-friendly error message at
>>> import error.
>>> obsoletes my previous patch
>>>
>>>
>>>
>>
>
>
> PATCH 0003
> ACK
>
> PATCH 0004
> I don't know
> I dont think that this change is needed, we enforce pep8 only for new 
> code,  those kind of random changes make git blame hard to read.
>
> PATCH 0005
> NACK
>
> If this is workaround for DNSSEC, it should be done only for DNSSEC 
> test not globally for all tests.
>
0003:
Pushed to:
master: b93137c1964690cc6c20ad5e187aa70cc414554c
ipa-4-2: 74c0bcce237faaba700ade6377753783d6a2a9bf


0005:
Pushed to:
master: b202afbcc0fe8cd1291784a3d261fce59b5646fd
ipa-4-2: aa381746610bb280a906f6d73edd20877da1877d




More information about the Freeipa-devel mailing list