[Freeipa-devel] [PATCHES] changes in preparation of replica promotion work

[Jan Cholasta]

On 27.8.2015 16:02, Simo Sorce wrote:
> On Thu, 2015-08-27 at 16:02 +0200, Jan Cholasta wrote:
>> On 27.8.2015 14:34, Simo Sorce wrote:
>>> On Thu, 2015-08-27 at 11:05 +0200, Jan Cholasta wrote:
>>>> On 27.8.2015 07:56, Jan Cholasta wrote:
>>>>> On 25.8.2015 20:43, Simo Sorce wrote:
>>>>>> On Wed, 2015-08-05 at 11:24 -0400, Simo Sorce wrote:
>>>>>>> On Wed, 2015-08-05 at 08:20 +0200, Jan Cholasta wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Dne 31.7.2015 v 12:46 Simo Sorce napsal(a):
>>>>>>>>> I've been carrying these patches in my tree for a while, I think it is
>>>>>>>>> time to put them in master as they stand on their own.
>>>>>>>>>
>>>>>>>>> Simo.
>>>>>>>>
>>>>>>>> Patch 530: ACK
>>>>>>>>
>>>>>>>> Patch 531: ACK
>>>>>>>>
>>>>>>>> Patch 532:
>>>>>>>>
>>>>>>>> The methods should be static methods:
>>>>>>>>
>>>>>>>>         @staticmethod
>>>>>>>>         def setOption(name, value):
>>>>>>>>         ...
>>>>>>>
>>>>>>> Care to explain why ?
>>>>>>> @staticmethod is not used anywhere else in that file.
>>>>>>
>>>>>> Rebased patches on master, made requested change +1 more patch.
>>>>>>
>>>>>> Simo.
>>>>>>
>>>>>
>>>>> Patch 532: ACK
>>>>>
>>>>> Patch 533: ACK
>>>>>
>>>>> Pushed to master: f57b687241fbc92d1138507210e87e9de465c507
>>>>>
>>>>> Honza
>>>>>
>>>>
>>>> Actually, there is a problem with patch 531: SASL mapping are added only
>>>> on replica.
>>>>
>>>> The attached patch fixes it.
>>>>
>>>
>>> This will break the promotion code, which needs to add the real sasl
>>> mappings later in the process.
>>>
>>> Can you leave the step in the non-common part of the setup for both
>>> server and replica installs ?
>>
>> OK, here you go.
>>
>
> LGTM
>
> Simo.
>

Pushed to master: 0914cb663e6ea72628776e79d93f20bf979c7b68

-- 
Jan Cholasta