[Freeipa-devel] patch acceptance criteria

[Rob Crittenden]

Lukas Slebodnik wrote:
> On (02/12/15 13:14), Rob Crittenden wrote:
>> Is it still mandatory that tests pass the unit tests before acceptance?
> Unit test could be executed as part of "%check" phase in spec files.
> I recently added C-base unit tests there.
> 
> I was not bale to run "make tests" there because many tests failed.
> If they require real IPA server for execution ( or lite server)
> then they are not unit test but integration tests.
> One solution would be to skip them or to usw cwrap[1] + lite server.
> So it can be run also in mock/koji which has many restrictions.

It would represent quite a lot of work but it may be a good idea to
investigate. Ipsilon uses cwrap for its tests so some of the
configuration can be gleaned from that.

I would definitely be opposed to this as part of the freeipa.spec in the
git tree. In Fedora it might help find problems when rawhide becomes
Fedora.next so it would provide some value there.

> 
> Also lint should be also part of "%check" phase and not part of
> ordinary build.
> BTW I could not see a lint[2] in fedora build at all. So I'm not sure
> if it is executed with upstream spec file.

It isn't there because the expectation is that lint already passes as
part of the release process. I don't see the value on running lint on
release tarballs.

I also want to keep the focus on the reviewer's responsibility to ensure
that patches do what they are supposed to and don't break things.

rob

> If someone wants to comply that it would take long time to build rpms
> then you might take a look how long glibc is built.
> http://koji.fedoraproject.org/koji/buildinfo?buildID=697271
> (half an hour on x86_64)
> 
>> I've seen a number of cases over the past couple of months where a
>> change goes through then shortly afterward a patch to fix the tests.
>> IMHO this should be caught in advance.
>>
>> Things slip through and goodness knows I've acked more than a few
>> patches without running the full suite. I just have a feeling it has
>> become more frequent lately.
>>
>> rob
> 
> LS
> 
> [1] https://cwrap.org/
> [2] https://kojipkgs.fedoraproject.org//packages/freeipa/4.2.3/1.1.fc23/data/logs/x86_64/build.log
>