[Freeipa-devel] patch acceptance criteria

[Jakub Hrozek]

On Thu, Dec 03, 2015 at 09:59:46AM -0500, Rob Crittenden wrote:
> Lukas Slebodnik wrote:
> > On (02/12/15 13:14), Rob Crittenden wrote:
> >> Is it still mandatory that tests pass the unit tests before acceptance?
> > Unit test could be executed as part of "%check" phase in spec files.
> > I recently added C-base unit tests there.
> > 
> > I was not bale to run "make tests" there because many tests failed.
> > If they require real IPA server for execution ( or lite server)
> > then they are not unit test but integration tests.
> > One solution would be to skip them or to usw cwrap[1] + lite server.
> > So it can be run also in mock/koji which has many restrictions.
> 
> It would represent quite a lot of work but it may be a good idea to
> investigate. Ipsilon uses cwrap for its tests so some of the
> configuration can be gleaned from that.

SSSD uses cwrap tests as well, Nikolai wrote tests that spin up an
openldap server and there are even tests that test against a Samba DC on
review..so IPA developers can also look into the SSSD tree.