[Freeipa-devel] [PATCH 0182] Fix pkcs11 python extension reference counting

[Martin Basti]

On 10/02/15 10:11, Jan Cholasta wrote:
> Hi,
>
> Dne 12.1.2015 v 13:11 Martin Basti napsal(a):
>> Part of DNSSEC (https://fedorahosted.org/freeipa/ticket/4657)
>>
>> Patch attached.
>
> 1) In P11_Helper_set_attribute, the return value can be only Py_None 
> or NULL, so why don't you use Py_XINCREF instead of the if/Py_INCREF?
>
> 2) In P11_Helper_find_keys, you sometimes return without decreasing 
> reference count on result_list or any items it may contain.
>
> Honza
>
Thank you,

updated patch attached.

-- 
Martin Basti

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0182.2-Fix-reference-counting-in-pkcs11-extension.patch
Type: text/x-patch
Size: 7205 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150210/647d1fc1/attachment.bin>