[Freeipa-devel] [PATCH 0182] Fix pkcs11 python extension reference counting

[Jan Cholasta]

Dne 10.2.2015 v 14:56 Martin Basti napsal(a):
> On 10/02/15 10:11, Jan Cholasta wrote:
>> Hi,
>>
>> Dne 12.1.2015 v 13:11 Martin Basti napsal(a):
>>> Part of DNSSEC (https://fedorahosted.org/freeipa/ticket/4657)
>>>
>>> Patch attached.
>>
>> 1) In P11_Helper_set_attribute, the return value can be only Py_None
>> or NULL, so why don't you use Py_XINCREF instead of the if/Py_INCREF?
>>
>> 2) In P11_Helper_find_keys, you sometimes return without decreasing
>> reference count on result_list or any items it may contain.
>>
>> Honza
>>
> Thank you,
>
> updated patch attached.
>

Thanks, ACK.

Pushed to:
master: dd607a35bcdad125c098f0e80c8b25efbe935acc
ipa-4-1: c198b5ab6537f26936554a9e2e5bfcbe3f371320

-- 
Jan Cholasta