[Freeipa-devel] Fix removal of ipa-kdc-proxy.conf symlink

Petr Vobornik pvoborni at redhat.com
Mon Jun 29 15:28:35 UTC 2015


On 06/29/2015 03:22 PM, Fraser Tweedale wrote:
> On Mon, Jun 29, 2015 at 10:54:50AM +0200, Christian Heimes wrote:
>> Hello,
>>
>> the attached patch fixes the first bug, that was reported by Fraser
>> today. installutils.remove_file() uses os.path.exists() to check if the
>> file still exists, which in turn uses stat(2). I have modified the
>> function to use os.path.lexists() instead. It doesn't follow symlinks.
>>
>> Because httpinstance first removes the target file
>> /etc/ipa/kdcproxy/ipa-kdc-proxy.conf before it tries to remove the
>> symlink /etc/httpd/conf.d/ipa-kdc-proxy.conf, the
>> installutils.remove_file() ignores the dangling symlink.
>>
>> Christian
>
> ACK
>

Pushed to master: 2842a83568301c85d340801daae42078333ce63d

Christian, could please provide [PATCH] in subject for new threads with 
patch? It is an established practice on freeipa-devel and it helps with 
mail filtering.
-- 
Petr Vobornik




More information about the Freeipa-devel mailing list