[Freeipa-devel] Fix removal of ipa-kdc-proxy.conf symlink

[Christian Heimes]

On 2015-06-29 17:28, Petr Vobornik wrote:
> On 06/29/2015 03:22 PM, Fraser Tweedale wrote:
>> On Mon, Jun 29, 2015 at 10:54:50AM +0200, Christian Heimes wrote:
>>> Hello,
>>>
>>> the attached patch fixes the first bug, that was reported by Fraser
>>> today. installutils.remove_file() uses os.path.exists() to check if the
>>> file still exists, which in turn uses stat(2). I have modified the
>>> function to use os.path.lexists() instead. It doesn't follow symlinks.
>>>
>>> Because httpinstance first removes the target file
>>> /etc/ipa/kdcproxy/ipa-kdc-proxy.conf before it tries to remove the
>>> symlink /etc/httpd/conf.d/ipa-kdc-proxy.conf, the
>>> installutils.remove_file() ignores the dangling symlink.
>>>
>>> Christian
>>
>> ACK
>>
> 
> Pushed to master: 2842a83568301c85d340801daae42078333ce63d
> 
> Christian, could please provide [PATCH] in subject for new threads with
> patch? It is an established practice on freeipa-devel and it helps with
> mail filtering.

I'm sorry that I forgot to include [PATCH] and my patch number. It's
Monday...

Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150629/7b289a86/attachment.sig>