[Freeipa-devel] [PATCH] 0048 Remove unused enable() method from DogtagInstance.

Martin Basti mbasti at redhat.com
Tue May 12 12:16:41 UTC 2015


On 12/05/15 13:53, David Kupka wrote:
> DogtagInstance.enable() overrides Service.enable() and does nothing 
> usefulll. Also removing it solves bug discovered recently in uninstall 
> procedure.
NACK

1)
this is used in step() call, which means the tomcatd will be enabled in 
systemd, and we do not want this.
Services should be disabled and managed just by ipactl.

2)
Which method now store state of tomcatd before IPA changes it?

To solve this please rename method to, for example, store_state(), and 
add appropriate description, or put backup_state() call into different 
appropriate step.

Martin^2

-- 
Martin Basti




More information about the Freeipa-devel mailing list