[Freeipa-devel] [PATCH] 0048 Remove unused enable() method from DogtagInstance.

[David Kupka]

On 05/12/2015 02:16 PM, Martin Basti wrote:
> On 12/05/15 13:53, David Kupka wrote:
>> DogtagInstance.enable() overrides Service.enable() and does nothing
>> usefulll. Also removing it solves bug discovered recently in uninstall
>> procedure.
> NACK
>
> 1)
> this is used in step() call, which means the tomcatd will be enabled in
> systemd, and we do not want this.
> Services should be disabled and managed just by ipactl.
>
> 2)
> Which method now store state of tomcatd before IPA changes it?
>
> To solve this please rename method to, for example, store_state(), and
> add appropriate description, or put backup_state() call into different
> appropriate step.
>
> Martin^2
>
Thanks for catching that, updated patch attached.

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0048.1-Rename-DogtagInstance-method-enable-to-_backup_state.patch
Type: text/x-patch
Size: 2073 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150512/d82cfb45/attachment.bin>