[Freeipa-devel] [PATCH 0048] fix ipa help command output errors

Martin Basti mbasti at redhat.com
Fri May 22 15:01:27 UTC 2015


On 22/05/15 16:08, Gabe Alford wrote:
> Hello,
>
> This should fix https://fedorahosted.org/freeipa/ticket/3584, and as 
> requested in the ticket, this should also fix 
> https://fedorahosted.org/freeipa/ticket/2284
>
> Thanks,
>
> Gabe
>
>
Thank you!

IMO your first part of fix only mask issue, not solving it.

This could be way, but I did not test it.

             out_encoding = getattr(outfile, 'encoding', None)
             if out_encoding is None:
                 out_encoding = 'utf-8'
             print >> outfile, unicode(string).encode(out_encoding)

Can you split this patch into 2 separate patches for each ticket please?

Martin^2

-- 
Martin Basti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150522/4beb226f/attachment.htm>


More information about the Freeipa-devel mailing list