[Freeipa-devel] [PATCH 0048] fix ipa help command output errors

[Gabe Alford]

On Fri, May 22, 2015 at 9:01 AM, Martin Basti <mbasti at redhat.com> wrote:

>  On 22/05/15 16:08, Gabe Alford wrote:
>
>  Hello,
>
>  This should fix https://fedorahosted.org/freeipa/ticket/3584, and as
> requested in the ticket, this should also fix
> https://fedorahosted.org/freeipa/ticket/2284
>
>  Thanks,
>
>  Gabe
>
>
>  Thank you!
>
> IMO your first part of fix only mask issue, not solving it.
>
> This could be way, but I did not test it.
>
>             out_encoding = getattr(outfile, 'encoding', None)
>             if out_encoding is None:
>                 out_encoding = 'utf-8'
>             print >> outfile,  unicode(string).encode(out_encoding)
>

I'm confused and maybe missing something here. If I run `ipa help dns |
bad_command`, shouldn't the command fail with only the following?

-bash: bad: command not found



>
> Can you split this patch into 2 separate patches for each ticket please?
>

Done


> Martin^2
>
> --
> Martin Basti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150522/3ab24e4e/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0048-Allow-ipa-help-command-to-run-when-ipa-client-instal.patch
Type: text/x-patch
Size: 894 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150522/3ab24e4e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0049-Do-not-print-traceback-when-pipe-is-broken.patch
Type: text/x-patch
Size: 866 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150522/3ab24e4e/attachment-0001.bin>