[Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

[Martin Basti]

On 09.11.2015 15:09, Oleg Fayans wrote:
> Hi guys,
>
> Here are first two automated testcases from this (so far incomplete) 
> testplan: http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan
>
> Testplan review is highly appreciated
>
>
>
>
PATCH 16: NACK

1)
What is the reason to add an unused parameter to 'domain_level' to 
install_topo()?
Also it is good practise to add new option as the last parameter.

2)
cab you in both tests specify a domain level with constant instead of 
number literal?

3)
both test call install_topo with custom domain level, but it cannot work 
because 1)  (did you run the test?)

4)
How the test "TestLevel1" is supposed to work?
Respectively why there is call of install_topo() that installs replica. 
As this test just tests that ipa-replica-prepare is not working anymore, 
is it worth to spend 20 minutes with installing replica and then just no 
tot use it? IMO to install master in install step is enough.

Martin^2

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151118/ed779a33/attachment.htm>