[Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

[Oleg Fayans]

Hi,

Here is the updated version of the patch (more tests + fixed the issues 
of the first one) + patch 0017, that implements the necessary changes in 
the background code, i. e. patch 16 does not work without patch 17

On 11/18/2015 05:20 PM, Martin Basti wrote:
>
>
> On 09.11.2015 15:09, Oleg Fayans wrote:
>> Hi guys,
>>
>> Here are first two automated testcases from this (so far incomplete)
>> testplan: http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan
>>
>> Testplan review is highly appreciated
>>
>>
>>
>>
> PATCH 16: NACK
>
> 1)
> What is the reason to add an unused parameter to 'domain_level' to
> install_topo()?
> Also it is good practise to add new option as the last parameter.
>
> 2)
> cab you in both tests specify a domain level with constant instead of
> number literal?
>
> 3)
> both test call install_topo with custom domain level, but it cannot work
> because 1)  (did you run the test?)
>
> 4)
> How the test "TestLevel1" is supposed to work?
> Respectively why there is call of install_topo() that installs replica.
> As this test just tests that ipa-replica-prepare is not working anymore,
> is it worth to spend 20 minutes with installing replica and then just no
> tot use it? IMO to install master in install step is enough.
>
> Martin^2
>

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ofayans-0016.1-First-part-of-replica-promotion-tests.patch
Type: text/x-patch
Size: 7466 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151125/f7a5eba7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ofayans-0017-Enabled-setting-domain_level-per-class.patch
Type: text/x-patch
Size: 3283 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151125/f7a5eba7/attachment-0001.bin>